Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept transactions by ID in pooledUserCommands #8293

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

mrmr1993
Copy link
Member

This allows pooledUserCommands to accept transactions encoded with either hashes or ids, to make them more consistent with transactionStatus.

This also can be used to get the hash of a transaction from its ID via GraphQL: you can send the transaction as an ID and query its hash in the output.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #8244

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Mar 16, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner March 16, 2021 22:08
@bkase
Copy link
Member

bkase commented Mar 16, 2021

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit cfcc95b into compatible Mar 17, 2021
@mrmr1993 mrmr1993 deleted the feature/payment-id-pooledUserCommands branch March 17, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants