-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for child processes #8486
Docs for child processes #8486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the docs could use some more details here to be in line with our new documentation guidelines. In general, I'd prefer if we don't make code changes along with the documentation PRs; I'm not totally sure these code changes are benign.
I'll move those changes to a separate PR, if after reading my justifications, you're still not convinced. |
Sorry for the delayed response. It's ok to leave them here, the justifications work for me. |
Add a
README
forChild_processes
.Notes:
Libp2p_helper
, which was added tomaster-qa
, but notcompatible
, yet. This mention will become valid in the near future, then.coda
tomina
, but not for environment variables, which still in use in the codebaseexit 99
when the prover or verifier dies is changed to afailwith
. I ran a demo node locally, killed the prover, and verified the daemon still exits. Reviewer:Coda_run.handle_crash
gets called in this case, is that OK?