Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use formatted exception printing for prover/verifier sub-monitors #8503

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Use formatted exception printing for prover/verifier sub-monitors #8503

merged 2 commits into from
Apr 21, 2021

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Apr 1, 2021

This PR switches the printing of exceptions raised in the prover/verifier monitors from stringified s-expressions to JSON-encoded Error.ts. This makes it easier to query them in a structured way, explore backtraces, etc.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 1, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner April 1, 2021 20:33
@mrmr1993 mrmr1993 added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Apr 20, 2021
@mrmr1993 mrmr1993 merged commit d4777a8 into compatible Apr 21, 2021
@mrmr1993 mrmr1993 deleted the feature/pretty-errors-scheduler branch April 21, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler