Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] fix link to contributing doc #8670

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Apr 16, 2021

No description provided.

@mimoo mimoo requested a review from bkase April 16, 2021 17:26
@mimoo mimoo requested a review from a team as a code owner April 16, 2021 17:26
@mimoo
Copy link
Contributor Author

mimoo commented Apr 16, 2021

wait so should I target the compatible branch instead?

@imeckler
Copy link
Member

Yep -- also I think there may be an issue with CI for the external contributor flow. In general I would make PRs from within the repo, just off a branch pushed to the minaprotocol remote rather than on a fork.

@mimoo mimoo force-pushed the mimoo/contributing branch from 39a06d6 to eaa7108 Compare April 16, 2021 21:41
@mimoo mimoo changed the base branch from develop to compatible April 16, 2021 21:41
@mimoo mimoo closed this Apr 19, 2021
@mimoo mimoo reopened this Apr 19, 2021
@mrmr1993 mrmr1993 merged commit 3b4eb6b into MinaProtocol:compatible Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants