-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query all direct-connected peers for all seed nodes in watchdog #8688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though we should probably get a second pair of eyes on this as I am not too familiar with the watchdog script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks effectively fine, if we're cool with in the short term seeds only querying their direct peers (better than what we do right now anyway, it would seem). I have some follow up questions on the long term strategy, but I'll follow up with those elsewhere
LGTM. Could you update the version number in |
… into node-status-metrics-query-direct-peers
This PR changes how we query peers in watchdog and make_report.py.
The intention is that we would query all the seed nodes for all their directly connected peers. See #8638 for more details.
This PR also add some more error reporting for the make_report.py.
This PR also fixed the following kinds of errors of the watchdog process:
fixed by checking the status of the pods before doing anything