More alert improvements #8689
Merged
More alert improvements #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthiskumar
added
the
ci-build-me
mrmr1993
approved these changes
Apr 20, 2021
imeckler
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O1NodesOutOfSyncfor when one of our nodes are out-of-syncFewBlocksPerHourto 30mins (and changed its name toFewBlocksPer30Mins) since it is a critical alert (O1NodesOutOfSync) when the time-frame is 1hrNoCoinbaseInBlocks. The impact of this is that an alert will fire if there are 2 (at most 3) consecutive blocks without coinbase. Some block producers might produce a block right after restarting and therefore may not have any snark work to add coinbase. Likeliness of this happening in two consecutive blocks seems lesser