Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit with code 1 if there is an error in ledger export #8720

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Exit with code 1 if there is an error in ledger export #8720

merged 1 commit into from
Apr 27, 2021

Conversation

mrmr1993
Copy link
Member

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #8706

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 22, 2021
@mrmr1993 mrmr1993 requested a review from a team as a code owner April 22, 2021 20:33
@mrmr1993 mrmr1993 changed the base branch from develop to compatible April 22, 2021 20:33
@mrmr1993 mrmr1993 added the ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR label Apr 22, 2021
@mrmr1993 mrmr1993 merged commit b5aebf5 into compatible Apr 27, 2021
@mrmr1993 mrmr1993 deleted the feature/error-code-export-staking branch April 27, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nholland94 nholland94 nholland94 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mina ledger export staking-epoch-ledger returns exit code of 0 even though it arguably is an error
2 participants
@mrmr1993 @nholland94