Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve-bad-balance-scripting Add fix-all-balances.sh script #8732

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Apr 26, 2021

Thank you for contributing to Mina! Please see CONTRIBUTING.md if you haven't
yet. In that doc, there are more details around how to start our CI.

Explain your changes here.

Explain how you tested your changes here.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

Closes #0000
Closes #0000

@lk86 lk86 requested review from a team as code owners April 26, 2021 20:22
Copy link
Member

@psteckler psteckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's useful to set a bound in the AWK file, so that once it sees a particular state hash, it exits, to prevent swapping valid balances

Also, init comment in PR should say how it was tested (per discussion last week)

Copy link
Member

@psteckler psteckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again, doesn't the Claimed message indicate where there's a swap? If the values aren't swapped, that message doesn't appear. That can be used to trigger calling the swapper, or not.

@psteckler psteckler added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 28, 2021
@mrmr1993 mrmr1993 merged commit 96fc732 into compatible Apr 28, 2021
@mrmr1993 mrmr1993 deleted the improve-bad-balance-scripting branch April 28, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants