Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only exec commands on running pods #8869

Merged
merged 3 commits into from
May 14, 2021
Merged

Conversation

ghost-not-in-the-shell
Copy link
Contributor

Fix another bug of watchdog. This should fix the SeedListDown alert in devnet2.

try:
resp = util.exec_on_pod(v1, namespace, pod_name, container_name, 'mina client status --json')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add the pod name in the error message we print below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@ghost-not-in-the-shell ghost-not-in-the-shell added ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR labels May 12, 2021
@deepthiskumar
Copy link
Member

Updated the image watchdog:0.4.11 with the changes from this PR

@mrmr1993 mrmr1993 merged commit 9b2f982 into compatible May 14, 2021
@mrmr1993 mrmr1993 deleted the fix/watchdog-get-chain-id branch May 14, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch ready-to-merge Adding this label will trigger mergify and trigger CI to run and merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants