Changes for OCaml 4.11.2 #8898
Merged
Changes for OCaml 4.11.2 #8898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
requested review from
bkase,
imeckler,
mrmr1993 and
a team
as code owners
psteckler
added
the
ci-build-me
5 tasks
This was referenced Jun 1, 2021
psteckler
changed the title
lk86
approved these changes
Jun 10, 2021
mrmr1993
requested changes
Jun 14, 2021
| @@ -165,10 +165,6 @@ let%test_unit "checkpoint read" = | |||
| ~expect:cp_sorted cp_alist ; | |||
| close db ; | |||
| close cp ; | |||
| let%bind () = File_system.remove_dir db_dir in | |||
There was a problem hiding this comment.
Do we need to remove these calls as part of this upgrade?
There was a problem hiding this comment.
I'd removed them because we get: pthread lock: Invalid argument.
I'll see if I can work around that.
There was a problem hiding this comment.
After removing these calls, and running the unit test, the temp directories no longer exist in /tmp. Could it be the unit test framework knows to do this?
mrmr1993
approved these changes
Jun 14, 2021
psteckler
removed
the
ci-build-me
psteckler
added
the
ci-build-me
mrmr1993
reviewed
Jun 16, 2021
src/lib/network_pool/snark_pool.ml
Outdated
| assert false | ||
| in | ||
| [%test_eq: Mock_snark_pool.Resource_pool.Diff.t list] | ||
| (List.sort ~compare rebroadcastable3) |
There was a problem hiding this comment.
Didn't you add these to make the unit test pass?
There was a problem hiding this comment.
I added the sorting, yes. The equality tests were deleted in compatible, for whatever reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow source code to be compiled with OCaml 4.11.2.
A couple of earlier PRs made some of the needed changes:
ignoreargumentsOther boilerplate changes:
[@sexp.opaque]annotations on types instead of thesexp_opaquetype constructor (this one breaks the versioned-type-change linter test in CI; that's a spurious failure)let%bindandlet%mapwith specified modules no longer mentionLet_syntax; instead ofAsync.Deferred, use justAsyncThe
opam.exportfile has been updated to use Jane St packages compatible with 4.11.2. Other packages have been updated as well. There are a few changes related to changes in the Jane St library structure (HeapbecomesPaired_heap, for example).The Docker Rosetta and toolchain files have been updated.
Warning 67, "unused functor parameter", is disabled for some signatures, which wasn't being reported in 4.07.1.
The submodules for forked libraries
async_kernel,graphql_ppx,ppx_optcomp, andrpc_parallelhave been updated, andREADMEs added to them to describe the forks.ppx_version, not a fork, is updated.A fork of
ppx_deriving_yojsonwas created, and added as a submodule, because the latest version compatible with other libraries generates polymorphic equality checks. That's a temporary situation, more recent versions of the library should work when OCaml and Jane St libraries are updated again.Updated the submodule references to
MinaProtocolfromCodaProtocolwhere applicable.