Fix/super catchup stuck at the tip #9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeckler
reviewed
Jun 24, 2021
| @@ -137,9 +137,17 @@ let tear_down {nodes; states; _} = | |||
| Hashtbl.clear states | |||
|
|
|||
| let set_state t (node : Node.t) s = | |||
| Hashtbl.decr t.states (Node.State.enum node.state) ; | |||
| Hashtbl.update t.states (Node.State.enum node.state) ~f:(function | |||
There was a problem hiding this comment.
Maybe refactor these two out into their own functions
lk86
added
the
ci-build-me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the snark-coordinator being stuck at catchup bug on devnet2.
What happened is that super-catchup didn't invalidate the cache of catchup blocks if we fail to download the state hashes for the missing blocks. This would cause subsequent catchup stuck on those blocks because we still have caches of those in the system and our system recognize blocks in caches as blocks under processing. So it would wait for those blocks forever.