-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/8407 spec ouroboros samasika consensus - skeleton and min window density #9307
Merged
jspada
merged 5 commits into
compatible
from
feature/8407-spec-ouroboros-samasika-consensus
Mar 29, 2022
Merged
Feature/8407 spec ouroboros samasika consensus - skeleton and min window density #9307
jspada
merged 5 commits into
compatible
from
feature/8407-spec-ouroboros-samasika-consensus
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08f3033
to
2307f60
Compare
ghost-not-in-the-shell
approved these changes
Oct 29, 2021
nholland94
requested changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just have some small nits, but there were a couple of details that seem to be missing.
vanishreerao
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
36e008e
to
a2ab609
Compare
mrmr1993
reviewed
Mar 24, 2022
* Add details about k-th predecessor edge case * Integrate review feedback from Matthew and Nathan
nholland94
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for tracking the chainsafe spec's work for creating the intial consensus spec (breadth first) and deep-dive into window density specification.
Closes #8407