Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lk86/fix-docker-permissions Use a smaller UserID for the mina user in docker #9326

Merged
merged 2 commits into from
Sep 2, 2021
Merged

lk86/fix-docker-permissions Use a smaller UserID for the mina user in docker #9326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c57ef30
lk86/fix-docker-permissions Use 65534 as the safe user ID for the min…
lk86 Aug 3, 2021
b3eff5a
Merge branch 'release/1.2.0' into lk86/fix-docker-permissions
lk86 Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dockerfiles/Dockerfile-mina-daemon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,14 @@ RUN echo "Building image with version $deb_version from repo $deb_release $deb_c
&& apt-get install -y --allow-downgrades "mina-$network=$deb_version"


# Move to a non-root UID in the future, for now stick to root for compatibility
# Move to a non-root UID in the future (specifically 65534, the maximum UID for most systems)
# for now stick to root for compatibility
ARG UID=0

# TODO: flesh out this feature + test
# Create a mina user to execute the daemon with
RUN mkdir /home/mina \
&& adduser --uid 192920 --disabled-password --gecos '' mina \
&& adduser --uid 65534 --disabled-password --gecos '' mina \
&& passwd -l mina \
&& chown -R mina:mina /home/mina

Expand Down