Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lk86/use-an-even-safer-user-id #9435

Merged
merged 9 commits into from
Sep 3, 2021
Merged

lk86/use-an-even-safer-user-id #9435

merged 9 commits into from
Sep 3, 2021

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Sep 3, 2021 •
edited
Loading

Use an even safer uid in docker to own the mina home directory

Tested by running CI in this PR, don't merge unless it passes

In hindsight MAX_UID was a dumb arbitrary value to choose as its not arbitrary, and there is a nobody user in the default /etc/passwd with UID 65534. 50000 seems much safer.

@lk86 lk86 requested a review from a team as a code owner September 3, 2021 03:21
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Sep 3, 2021
@lk86 lk86 requested a review from a team as a code owner September 3, 2021 03:30
@lk86
Revert "Merge remote-tracking branch 'origin/fix/rm-gc-stat' into lk8…
d814305 
…6/use-an-even-safer-user-id"

This reverts commit a286143, reversing
changes made to 4ff5f14.
@lk86 lk86 merged commit c3b99ee into release/1.2.0 Sep 3, 2021
@lk86 lk86 deleted the lk86/use-an-even-safer-user-id branch September 3, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lk86 @deepthiskumar