Set chain status when adding intermediate blocks #9908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding blocks to the archive db, they are marked as pending to start. For blocks
k
or more above the highest canonical block, we can mark additional blocks as canonical.If there are missing blocks added, they may be below the highest canonical block, and we weren't updating their chain status. In this PR, we add that update.
Algorithm:
Tested by extracting some blocks from the db, deleting the blocks from the db, then re-adding them, verifying that the re-added blocks have the same chain statuses as before. Also tried the same experiment with precomputed blocks, instead of extracted extensional blocks. Also ran the missing blocks auditor, which does consistency checks on chain statuses.