Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update make clean #9952

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Update make clean #9952

merged 1 commit into from
Jan 24, 2022

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Dec 21, 2021 •
edited
Loading

Update makefile with a small addition to make clean.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner December 21, 2021 19:17
@yorickvP yorickvP added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Dec 22, 2021
@georgeee georgeee force-pushed the georgeee/fix-compatible-2021-12-21 branch from 5f84f33 to 06145a2 Compare January 12, 2022 23:13
@georgeee georgeee force-pushed the georgeee/fix-compatible-2021-12-21 branch from 06145a2 to 66f2cc1 Compare January 24, 2022 18:46
@psteckler psteckler merged commit aee5447 into compatible Jan 24, 2022
@psteckler psteckler deleted the georgeee/fix-compatible-2021-12-21 branch January 24, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelarogbonlo samuelarogbonlo samuelarogbonlo approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@georgeee @mrmr1993 @samuelarogbonlo @yorickvP @psteckler