Remove usage of deprecated utf8_encode function #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utf8_encode is deprecated in PHP 8.2. Fortunately, we're already making use of iconv, and it's straightforward enough to use iconv to convert from ISO-8859-1 instead of utf8_encode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf8_encodeis deprecated in PHP 8.2. Fortunately, we're already making use of iconv, and it's straightforward enough to useiconvto convert from ISO-8859-1 instead ofutf8_encode.I have to admit I'm not entirely clear on the purpose of this conversion. It appears to have been added quite a while ago in a08a28a, and may not be relevant anymore in newer PHP versions? Hard for me to say.