Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in function _WM_init_reverb in file reverb.c #210

Closed
M-HT opened this issue Aug 22, 2019 · 1 comment
Closed

Errors in function _WM_init_reverb in file reverb.c #210

M-HT opened this issue Aug 22, 2019 · 1 comment

Comments

@M-HT
Copy link

M-HT commented Aug 22, 2019

I don't know what the reverb engine is actually doing, but AFAICT all uses of variable i in lines 186-221 should be changed to variable j, otherwise there are uninitialized values and other unpleasant side-effects.
sezero added a commit that referenced this issue Aug 22, 2019
@sezero
reverb.c (_WM_init_reverb): fix loop variable (bug #210)
3051311
sezero added a commit that referenced this issue Aug 22, 2019
@sezero
reverb.c (_WM_init_reverb): fix loop variable (bug #210)
d2763e6
@sezero
Copy link
Contributor

sezero commented Aug 22, 2019

You, sir, seem correct. Should be fixed now.

wildmidi-0.3 branch:
3051311

master (0.4.x):
d2763e6

@sezero sezero closed this as completed Aug 22, 2019
@sezero sezero mentioned this issue Nov 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sezero @M-HT