cmake: use project-level variables, not top-level variables #214
Conversation
|
Cool! Just needs a little love apparently... |
CMakeLists.txt
Outdated
| CMAKE_MINIMUM_REQUIRED(VERSION 2.8.11) | ||
| CMAKE_POLICY(SET CMP0072 NEW) |
There was a problem hiding this comment.
Instead of setting the policy, could we just bump our cmake requirement?
There was a problem hiding this comment.
What do we have to do with FindOpenGL() to need this CMP0072 policy setting? (see: https://cmake.org/cmake/help/v3.11/policy/CMP0072.html)
There was a problem hiding this comment.
We're not an OpenGL consumer, so we shouldn't need to bother with this nor set a policy for it.
There was a problem hiding this comment.
Well, that's exactly the reason I asked, and it seems like the actual author lost interest in his own pull request..
There was a problem hiding this comment.
Sorry for the radio silence! It's been very busy at work, but I'll try to find time this week to get this PR ready!
|
It should be OK now, though travis failed, but apparently while installing build dependencies on macOS?. I'm pretty sure is not related to this PR. |
|
Yeah, I'll have a look at the MacOS stuff when I have free cycles. Thanks |
This PR replaces CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR with PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR. This is more correct. It makes possible to add WildMidi as a submodule in a parent project and link it with:
It should have no effect on WildMidi itself.