Update CMake project #217

winterheart · 2020-10-30T17:09:52Z

Update cmake requirements to 3.1 and rewrite project with features that enhanced in 3.1 version. Added GNUInstallDirs extension for installing target, added exported targets for reuse in external CMake projects.

Update and cleanup project.

Simplify project for install targets, remove redundant variables.

Adding files for external CMake projects. External project can now call find_package(WildMidi) and use WildMidi::libwildmidi_dynamic and WildMidi::libwildmidi_static dependencies.

psi29a · 2020-11-01T09:28:45Z

@winterheart Thanks for the re-write!
Can you also bump the MacOS version in travis so that we can have some coverage on that side please?
https://travis-ci.org/github/Mindwerks/wildmidi/jobs/740251599

winterheart · 2020-11-01T16:27:16Z

I was intended to switch Github Actions (#216) since there is easy to configuration and maintain. Anyway, Travis configuration updated.

psi29a · 2020-11-01T21:43:30Z

Thanks!

sezero · 2020-11-01T22:06:07Z

I get the following error when trying to cross-compile for windows x64:

cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-MinGW64.cmake ..
-- The C compiler identification is GNU 4.5.4
-- Check for working C compiler: /opt/cross_win64/bin/x86_64-w64-mingw32-gcc
-- Check for working C compiler: /opt/cross_win64/bin/x86_64-w64-mingw32-gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Setting build type to 'Debug' as none was specified.
-- Build Type: Debug
-- Performing Test HAVE___BUILTIN_EXPECT
-- Performing Test HAVE___BUILTIN_EXPECT - Success
-- Performing Test HAVE_C_INLINE
-- Performing Test HAVE_C_INLINE - Success
-- Performing Test HAVE_C___INLINE__
-- Performing Test HAVE_C___INLINE__ - Success
-- Performing Test HAVE_C___INLINE
-- Performing Test HAVE_C___INLINE - Success
-- Performing Test HAVE_NO_UNDEFINED
-- Performing Test HAVE_NO_UNDEFINED - Success
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
CMake Error at src/CMakeLists.txt:217 (INSTALL):
  INSTALL Library TARGETS given no DESTINATION!


-- Configuring incomplete, errors occurred!

sezero · 2020-11-02T03:49:11Z

Well, here is another gem: This time building for linux with static library enabled:

$ cmake -DCMAKE_BUILD_TYPE=Release -DWANT_STATIC=1 .
-- The C compiler identification is GNU 7.3.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Build Type: Release
-- Performing Test HAVE_VISIBILITY_DEFAULT
-- Performing Test HAVE_VISIBILITY_DEFAULT - Success
-- Performing Test HAVE_VISIBILITY_HIDDEN
-- Performing Test HAVE_VISIBILITY_HIDDEN - Success
-- Performing Test HAVE___BUILTIN_EXPECT
-- Performing Test HAVE___BUILTIN_EXPECT - Success
-- Performing Test HAVE_C_INLINE
-- Performing Test HAVE_C_INLINE - Success
-- Performing Test HAVE_C___INLINE__
-- Performing Test HAVE_C___INLINE__ - Success
-- Performing Test HAVE_C___INLINE
-- Performing Test HAVE_C___INLINE - Success
-- Performing Test HAVE_NO_UNDEFINED
-- Performing Test HAVE_NO_UNDEFINED - Success
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- Found ALSA: /usr/lib64/libasound.so (found version "1.1.5") 
-- Found OpenAL: /usr/lib64/libopenal.so  
-- Looking for OSS...
-- Looking for include file sys/soundcard.h
-- Looking for include file sys/soundcard.h - found
-- Looking for include file machine/soundcard.h
-- Looking for include file machine/soundcard.h - not found
-- Looking for include file soundcard.h
-- Looking for include file soundcard.h - not found
-- Performing Test OSS_FOUND
-- Performing Test OSS_FOUND - Success
-- Found OSS.
-- M_LIBRARY: /usr/lib64/libm.so
CMake Error at src/CMakeLists.txt:210 (INSTALL):
  INSTALL TARGETS given no ARCHIVE DESTINATION for static library target
  "libwildmidi_static".


-- Configuring incomplete, errors occurred!

Either fix this crap or revert these changesets.

winterheart · 2020-11-02T09:57:12Z

@sezero can you please post cmake --version and cmake --trace -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-MinGW64.cmake .. output.
I tried every available configuration, and don't get same errors.

sezero · 2020-11-02T10:28:13Z

@sezero can you please post cmake --version and cmake --trace -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-MinGW64.cmake .. output.

$ PATH=$HOME/opt/cmake3.9/bin:$PATH cmake --version
cmake version 3.9.6

CMake suite maintained and supported by Kitware (kitware.com/cmake).

$ PATH=$HOME/opt/cmake3.9/bin:$PATH cmake --trace -DCMAKE_TOOLCHAIN_FILE=cmake/Toolchain-MinGW64.cmake . &> ../trace.txt
Gzip'ed trace.txt attached.
trace.txt.gz

sezero · 2020-11-02T10:46:35Z

In case you need, for the other setup:

$ cmake --version
cmake version 3.11.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).

$ CC=x86_64-w64-mingw32-gcc CXX=x86_64-w64-mingw32-g++ cmake --trace . &> trace1.txt
Gzipped trace1.txt attached
trace1.txt.gz

$ cmake --trace -DWANT_STATIC=1 . &> trace2.txt
Gzipped trace2.txt attached
trace2.txt.gz

winterheart · 2020-11-02T11:25:12Z

Can you please try this branch - https://github.com/winterheart/wildmidi/tree/cmake-2 (commit 4e37c97)

sezero · 2020-11-02T11:34:41Z

Can you please try this branch - https://github.com/winterheart/wildmidi/tree/cmake-2 (commit 4e37c97)

Doesn't make a difference:

$ git log|head -5
commit 4e37c975ef77b18dfd20f23b1cb9a60a3cc45e4d
Author: Azamat H. Hackimov <[email protected]>
Date:   Mon Nov 2 13:57:14 2020 +0300

    Specify ARCHIVE and RUNTIME destinations for INSTALL

Neither with mingw:

-- Check if the system is big endian - little endian
CMake Error at src/CMakeLists.txt:231 (INSTALL):
  INSTALL Library TARGETS given no DESTINATION!


-- Configuring incomplete, errors occurred!

Nor with -DWANT_STATIC=1:

CMake Error at src/CMakeLists.txt:231 (INSTALL):
  INSTALL TARGETS given no ARCHIVE DESTINATION for static library target
  "libwildmidi_static".


-- Configuring incomplete, errors occurred!

sezero · 2020-11-02T11:44:37Z

... And it fails even without specifying any options:

$ PATH=$HOME/opt/cmake3.9/bin:$PATH cmake .
[...]
CMake Error at src/CMakeLists.txt:231 (INSTALL):
  INSTALL TARGETS given no LIBRARY DESTINATION for shared library target
  "libwildmidi_dynamic".

winterheart · 2020-11-02T14:05:06Z

@sezero please test new changes winterheart@c03732a

sezero · 2020-11-02T15:41:07Z

@sezero please test new changes winterheart@c03732a

Seems to work. Send a new pull req. with the fix.

Fix regression introduced in Mindwerks#217. MinGW uses own layout install, so DLLs and executables goes to RUNTIME, static libs - to ARCHIVE destinations. Additional optimizations for installation targets.

Fix regression introduced in #217. MinGW uses own layout install, so DLLs and executables goes to RUNTIME, static libs - to ARCHIVE destinations. Additional optimizations for installation targets.

winterheart added 4 commits October 30, 2020 01:32

Update CMake requirements to 3.1

d49d72b

Update and cleanup project.

Use GNUInstallDirs for install targets

2a17324

Simplify project for install targets, remove redundant variables.

Optimizing wildmidi_executable_SRCS list usage

9595b8a

Add exported target configuration

544b785

Adding files for external CMake projects. External project can now call find_package(WildMidi) and use WildMidi::libwildmidi_dynamic and WildMidi::libwildmidi_static dependencies.

winterheart added 2 commits November 1, 2020 16:45

Reformat Travis YAML with proper indents.

610306d

Update travis configuration

3262b15

winterheart force-pushed the cmake branch from e9e4946 to 3262b15 Compare November 1, 2020 16:03

psi29a merged commit 9755157 into Mindwerks:master Nov 1, 2020

winterheart mentioned this pull request Nov 2, 2020

Specify ARCHIVE and RUNTIME destinations for INSTALL #218

Merged

sezero mentioned this pull request Nov 7, 2020

Getting ready for 0.4.4, outstanding issues #222

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CMake project #217

Update CMake project #217

winterheart commented Oct 30, 2020

psi29a commented Nov 1, 2020

winterheart commented Nov 1, 2020

psi29a commented Nov 1, 2020

sezero commented Nov 1, 2020

sezero commented Nov 2, 2020

winterheart commented Nov 2, 2020

sezero commented Nov 2, 2020

sezero commented Nov 2, 2020 •

edited

Loading

winterheart commented Nov 2, 2020

sezero commented Nov 2, 2020

sezero commented Nov 2, 2020

winterheart commented Nov 2, 2020

sezero commented Nov 2, 2020 •

edited

Loading

Update CMake project #217

Update CMake project #217

Conversation

winterheart commented Oct 30, 2020

psi29a commented Nov 1, 2020

winterheart commented Nov 1, 2020

psi29a commented Nov 1, 2020

sezero commented Nov 1, 2020

sezero commented Nov 2, 2020

winterheart commented Nov 2, 2020

sezero commented Nov 2, 2020

sezero commented Nov 2, 2020 • edited Loading

winterheart commented Nov 2, 2020

sezero commented Nov 2, 2020

sezero commented Nov 2, 2020

winterheart commented Nov 2, 2020

sezero commented Nov 2, 2020 • edited Loading

sezero commented Nov 2, 2020 •

edited

Loading

sezero commented Nov 2, 2020 •

edited

Loading