Migrate forge -> neoforge #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
commented
Dec 28, 2023
MattSturgeon
commented
Dec 28, 2023
Comment on lines
-16
to
-31
| loom { | ||
| forge { | ||
| convertAccessWideners = true | ||
| extraAccessWideners.add loom.accessWidenerPath.get().asFile.name | ||
|
|
||
| mixinConfig "freecam-common.mixins.json" | ||
| mixinConfig "freecam-forge.mixins.json" | ||
| } | ||
| } | ||
|
|
||
| afterEvaluate { | ||
| // FIXME: arch-loom only does this for tasks.remapJarTask, | ||
| // meaning our variant tasks don't get AccessTransformers. | ||
| tasks.withType(RemapJarTask).each { | ||
| Aw2At.setup(project, it) | ||
| } |
There was a problem hiding this comment.
Glad all this is gone.
Some of this can be backported. See #141.
MattSturgeon
force-pushed
the
neoforge
branch
from
7566ed1 to
f03414d
Compare
Neoforge have deprecated `requires = true` in favor of `type = "required"`.
It doesn't support Neofore.
|
I was able to get past the dev-run issue by removing the deprecated 'mandatory' field (used Looks like it was just Neoforge strictly enforcing the deprecation when in the dev environment: neoforged/FancyModLoader#60. I also ran this gradle command for good measure: ./gradlew -Dloom.refresh=true tasksDevlogin turned out to be an issue too, I've disabled it for now. See PlanetTeamSpeakk/DevLogin#16. |
This isn't needed on Neoforge. This reverts commit 977d6e8
|
Reverting the LexForge 'Show Player' fix was enough to fix that issue. I guess Neoforge doesn't have that quirk. |
Merged
|
Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the forge project to neoforge.
I've noticed a couple issues so far (both fixed now):
Failed to find system mod: minecraft".Fixes #133
Fixes #135