Drop DevLogin #150
Merged
Drop DevLogin #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
added
enhancement
MattSturgeon
added a commit
to MattSturgeon/Freecam
that referenced
this pull request
Jan 14, 2024
You can debug logged in using DevAuth[1] instead, without us needing to maintain anything. [1]: https://github.com/DJtheRedstoner/DevAuth
MattSturgeon
force-pushed
the
build/drop-devlogin
branch
from
1b0ebd7 to
7f8a342
Compare
You can debug logged in using DevAuth[1] instead, without us needing to maintain anything. [1]: https://github.com/DJtheRedstoner/DevAuth
MattSturgeon
force-pushed
the
build/drop-devlogin
branch
from
7f8a342 to
a286b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started off as just dropping DevLogin; as per this comment, however I figured it'd be nice to document the ability to run logged in via DevAuth...
CONTRIBUTING.mdsnowballed from there, although I've left it unfinished as it isn't the focus of this PR.TBH most of the content should probably be replaced with links to external documentation. Having a wall of text covering stuff that most devs probably already know is only going to mask the useful info such as multi-platform & multi-variant info.
I'll let you decide if you'd rather merge with/without the documentation. You could just cherry-pick 98d13ef into main.
If you like the idea of a CONTRIBUTING doc, but not this iteration, we can always look at it again in another PR. Alternatively, this could be the starting point and another PR could improve on it.
EDIT: removed the documentation for now.