Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with exact duplicates not being returned #35

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: issue with exact duplicates not being returned #35

merged 1 commit into from
Jan 24, 2025

Conversation

stephantul
Copy link
Member

@stephantul stephantul commented Jan 17, 2025 •
edited
Loading

Closes #34

This PR solves an issue where exact duplicates had empty duplicates fields. This was an oversight.

@stephantul stephantul changed the title Fix issue with single records fix: issue with exact duplicates not being returned Jan 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
semhash/index.py 100.00% <ø> (ø)
semhash/records.py 100.00% <100.00%> (ø)
semhash/semhash.py 96.74% <100.00%> (+0.31%) ⬆️
semhash/utils.py 100.00% <ø> (+20.00%) ⬆️

@stephantul stephantul requested a review from Pringled January 17, 2025 06:08
@stephantul stephantul merged commit 662833f into main Jan 24, 2025
5 checks passed
@stephantul stephantul deleted the add-exact-duplicate branch January 24, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to keep exact duplicates
3 participants
@stephantul @codecov-commenter @Pringled