Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debugging AssertResourceFilteredCount issues easier #199

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

rabbitfang
Copy link
Collaborator

  • If the assert fails, it now logs which part of the filter matched or didn't.
  • Refactors ResourceFilter to group the elements of each filter (test and stringer) together. This should make it easier to add new filter options in the future.

- If the assert fails, it now logs which part of the filter matched or didn't.
- Refactors ResourceFilter to group the elements of each filter (test and stringer) together. This should make it easier to add new filter options in the future.
@rabbitfang rabbitfang requested review from a team and eljevakovic as code owners July 11, 2022 03:54
@rabbitfang
Copy link
Collaborator Author

This PR conflicts slightly with #197, which adds a DisplayIdPrefix filter option, but the conflict should be easy to resolve.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #199 (7f3dbbe) into main (9e24b89) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   73.17%   73.66%   +0.48%     
==========================================
  Files         104      104              
  Lines        5447     5486      +39     
==========================================
+ Hits         3986     4041      +55     
+ Misses       1191     1178      -13     
+ Partials      270      267       -3     
Impacted Files Coverage Δ
pkg/testingutil/type.go 100.00% <ø> (ø)
pkg/testingutil/chan.go 100.00% <100.00%> (ø)
pkg/testingutil/filter.go 100.00% <100.00%> (+10.34%) ⬆️
pkg/testingutil/model.go 51.42% <100.00%> (+15.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e24b89...7f3dbbe. Read the comment docs.

@rabbitfang rabbitfang merged commit 12d344a into main Jul 22, 2022
@rabbitfang rabbitfang deleted the feature/integration-test-debugging branch July 22, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant