Update the installation instructions in the README

[afbjorklund]

• Move documentation sections to right place
• Use install instead of cp -a for selinux
• Prefer using binaries and don't rebuild
• Add make targets for build and install

Issue:

• Improving the cri-dockerd repository as a resource for end-users #154

---

Don't duplicate all the strange go flags in the README, and don't rebuild the binary again during install.

Syntax had to be modified slightly in the Makefile, since it normally runs with SHELL=/bin/sh (not bash)

Mention that there are packages, although they might not exist for all distributions and all architectures.

Systemd units should normally be installed to the prefix location, only overrides and custom config in /etc

[afbjorklund]

@neersighted

[afbjorklund]

Note that a lot of external documentation is linking directly towards the section in the README:

https://github.com/mirantis/cri-dockerd#build-and-install

[afbjorklund]

It would be nice if this was documented on docker.com, next to the other Docker Engine installation.

And if the cri-dockerd packages were available from the Docker repositories, to install with apt or yum.

[neersighted]

README changes LGTM; Makefile needs a spot of work.

[neersighted]

Note that a lot of external documentation is linking directly towards the section in the README:

https://github.com/mirantis/cri-dockerd#build-and-install

Yeah, #154 for sure there; they probably shouldn't be linking here, but at the same time, we might need to be pragmatic in the short term.

It would be nice if this was documented on docker.com, next to the other Docker Engine installation.

And if the cri-dockerd packages were available from the Docker repositories, to install with apt or yum.

This is an interesting idea/somewhat promising. I think it's another discussion entirely, but I am in an excellent position to make it happen (if we decide to) in my current role.

That being said, there are technical obstacles to this right now (that I am currently working to solve for other packages); there are organizational barriers as well, but if we lean this direction, I think I can overcome them.

[afbjorklund]

I know, Docker only supports Docker Desktop and does not support Docker Engine. But still, it would be nice...

Docker Engine is an open source project, supported by the Moby project maintainers and community members. Docker doesn’t provide support for Docker Engine. Docker provides support for Docker products, including Docker Desktop, which uses Docker Engine as one of its components.

[neersighted]

That's not really the challenge; Docker Inc. still builds Docker CE after all. The issues are mostly technical.

The organizational issues are more 'why:'

• Why not ship it with Docker CE?
• Or, why not ship it standalone?
• Who is the user for this? Will they actually come to download.docker.com?
• download.docker.com hosts Moby and Docker Inc. code; is it expected to add a Mirantis project there?
• Should cri-dockerd get more attention from Moby maintainers/potentially become part of the Moby project?

All easily overcome if we move that direction, but I don't have all the answers yet myself.

[neersighted]

/cc @nwneisen

[neersighted]

LGTM

[afbjorklund]

The real question is when the docker CRI plugin will be available, so that users don't need a separate shim anymore...

https://kubernetes.io/blog/2018/05/24/kubernetes-containerd-integration-goes-ga/

Anyway, it is out of topic and out of scope for this README. The "docker" runtime users will have to make do with this:

https://kubernetes.io/docs/setup/production-environment/container-runtimes/#docker

[neersighted]

I'm not sure what "the docker plugin" is -- do you mean building CRI directly in to dockerd?

[afbjorklund]

there's just an odd demographic coming here.

If there are better instructions in some other place, it would be possible to add a link to it in this repository README.

[nwneisen]

LGTM. Thank you for updating these!

The builds will fail due to another issue I'm looking at. Feel free to merge these in since they should have no effect on the builds.

[neersighted]

You'll need to hit the button; neither @afbjorklund or I have the button 😅