Add golanglint-ci for static checking

[ranyodh]

The PR adds CI (and local make targets) for static checks using golangling-ci.

Removed check-generate-code CI job as it is not really required and takes a long time to run.

[nwneisen]

@ranyodh Can you also change the linter in all the other repos to this one?

[nwneisen]

There is also an issue opened by someone who wanted doc headers enforced in CI. We should look for a linter to do that

[ranyodh]

@ranyodh Can you also change the linter in all the other repos to this one?

Created this ticket for it: https://mirantis.jira.com/browse/BOP-1272

[ranyodh]

There is also an issue opened by someone who wanted doc headers enforced in CI. We should look for a linter to do that

There is a linter in golangci-lint revive (which is a drop in replacement or golint) that has a rule to check for it. I find it peculiar that they decide to exclude that rule by default (even after you enable the linter and configure it for doc checking).

Anyways, after enabling the linter and including the check, I get:

internal/tls/tls.go:61:18: Error return value of `file.Close` is not checked (errcheck)
        defer file.Close()
                        ^
internal/middlewares/middlewares.go:10:1: exported: exported function GetMiddlewares should have comment or be unexported (revive)
func GetMiddlewares() []runtime.Middleware {
^
exit status 1
make: *** [lint] Error 1

It also prints error with Close() function which could be annoying. Will look into a bit more later.