Avoid mutable default arguments

Miserlou · Jan 16, 2017 · b1b7813 · b1b7813
1 parent a5889b4
commit b1b7813
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/zappa/zappa.py b/zappa/zappa.py
@@ -629,14 +629,16 @@ def remove_from_s3(self, file_name, bucket_name):
     ##
 
     def create_lambda_function(self, bucket, s3_key, function_name, handler, description="Zappa Deployment",
-                               timeout=30, memory_size=512, publish=True, vpc_config=None, environment_variables={}):
+                               timeout=30, memory_size=512, publish=True, vpc_config=None, environment_variables=None):
         """
         Given a bucket and key of a valid Lambda-zip, a function name and a handler, register that Lambda function.
         """
         if not vpc_config:
             vpc_config = {}
         if not self.credentials_arn:
             self.get_credentials_arn()
+        if not environment_variables:
+            environment_variables = {}
 
         response = self.lambda_client.create_function(
             FunctionName=function_name,
@@ -673,7 +675,7 @@ def update_lambda_function(self, bucket, s3_key, function_name, publish=True):
         return response['FunctionArn']
 
     def update_lambda_configuration(self, lambda_arn, function_name, handler, description="Zappa Deployment",
-                                    timeout=30, memory_size=512, publish=True, vpc_config=None, environment_variables={}):
+                                    timeout=30, memory_size=512, publish=True, vpc_config=None, environment_variables=None):
         """
         Given an existing function ARN, update the configuration variables.
         """
@@ -683,6 +685,8 @@ def update_lambda_configuration(self, lambda_arn, function_name, handler, descri
             vpc_config = {}
         if not self.credentials_arn:
             self.get_credentials_arn()
+        if not environment_variables:
+            environment_variables = {}
 
         response = self.lambda_client.update_function_configuration(
             FunctionName=function_name,