Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: パスキーに対応 #149

Merged
merged 4 commits into from
Aug 22, 2023
Merged

feat: パスキーに対応 #149

merged 4 commits into from
Aug 22, 2023

Conversation

u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Aug 15, 2023

What

既存のWebAuthnの実装を @simplewebauthn/server@github/webauthn-json ベースに書き直し、パスキーが使えるようにした

Why

misskey-dev#11054
misskey-dev#8691
misskey-dev#9344
misskey-dev#9249
misskey-dev#11040

Additional info (optional)

  • challengeの値をDBに保存していたのをRedisに保存するようにした
  • 既に登録されていたセキュリティキーでログインしようとするとマイグレーションするようになっている

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@u1-liquid u1-liquid merged commit 690a4d5 into MisskeyIO:io Aug 22, 2023
@u1-liquid u1-liquid deleted the feat-passkey branch August 22, 2023 23:55
syuilo added a commit to misskey-dev/misskey that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants