コンテナイメージのビルド & 保管をGitHub Container Registryにする #77
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laica-Lunasys
changed the title
Laica-Lunasys
changed the title
Laica-Lunasys
commented
Apr 9, 2023
Comment on lines
+34
to
+36
| - name: Prepare image tags | ||
| run: | | ||
| echo "FORMATTED_BRANCH_NAME=$(echo ${{ github.ref_name }} | sed -e 's/\//-/g' )" >> $GITHUB_ENV |
There was a problem hiding this comment.
イメージタグにブランチ名を使うようにしてる。
んだけど、イメージタグには / が使えないので - に置き換えておく
(ブランチ名に / を使うなという話でもある)
Comment on lines
+49
to
+50
| ghcr.io/misskeyio/misskey:latest | ||
| ghcr.io/misskeyio/misskey:${{ env.FORMATTED_BRANCH_NAME }} |
There was a problem hiding this comment.
latest と一緒にブランチ名をタグ付けしておく (ブランチ名 or タグ付けしていればタグ名)
| jobs: | ||
| push_to_registry: | ||
| name: Push Docker image to GitHub Container Registry | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
latest を使うとlatestで使用されるバージョンが変わると厄介するかもしれないので。
riku6460
approved these changes
Apr 9, 2023
riku6460
reviewed
Apr 9, 2023
riku6460
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Additional info (optional)