Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask client to confirm telemetry on launch #382

Closed
SuperSandro2000 opened this issue Jan 28, 2021 · 8 comments
Closed

Ask client to confirm telemetry on launch #382

SuperSandro2000 opened this issue Jan 28, 2021 · 8 comments

Comments

@SuperSandro2000
Copy link
Contributor

Will there be an option to disable telemetry entirely?

@MisterTea
Copy link
Owner

There's a telemetry option in et.cfg to disable it server-side and there's the --telemetry option to disable it on the client.

@SuperSandro2000
Copy link
Contributor Author

Did you think about disabling it by default? Especially in the open source community it is considered not nice and sometimes even rude to enable telemetry by default.

@MisterTea
Copy link
Owner

Can you elaborate on that?

I'm collecting crash logs using crashpad, and also collecting LOG(ERROR) and LOG(FATAL). The only thing I'm using the logs for is to make ET better.

@SuperSandro2000
Copy link
Contributor Author

You are sending the data to sentry which most likely collects personal data which probably requires a privacy policy. So far the readme does not contain any information about this and trying to hide such things looks always very suspicious even you just try to get more insights into crashes. If you would be open about it, would make it easy to disable and opt-in rather than opt-out it would be less of a problem for most people.

@MisterTea MisterTea changed the title Disable telemetry Ask client to confirm telemetry on launch Jan 31, 2021
@MisterTea
Copy link
Owner

Sentry only collects the data I send it (and possibly the IP address of the sender)

@MisterTea
Copy link
Owner

@SuperSandro2000 Please take a look at #395 and give me your thoughts.

MisterTea added a commit that referenced this issue Feb 17, 2021
… address from logging. #382 (#395)

* Alert user about telemetry and give instructions to remove.  Remove IP address from logging.  #382

* fix errors

* increase xcode rev

* move some external code to submodules

* more codecov cleanup

* fix race condition

* fix fd on console

* move another print to warning

* more logging fixes

* consolidate cmake install
@kyeshmz
Copy link

kyeshmz commented Aug 12, 2021

Yeah, this is one thing that is stopping me from using this, still not really clear how to disable, as et --telemetry false doesnt seem like the correct option, and there is no real clear documentation, I don't know how to turn it off. Much rather it be opt in.

@MisterTea
Copy link
Owner

Yeah, this is one thing that is stopping me from using this, still not really clear how to disable, as et --telemetry false doesnt seem like the correct option, and there is no real clear documentation, I don't know how to turn it off. Much rather it be opt in.

What you wrote should work. Let me verify and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants