Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and fix logic holes #138

Merged
merged 4 commits into from
Sep 26, 2018
Merged

Add tests and fix logic holes #138

merged 4 commits into from
Sep 26, 2018

Conversation

MisterTea
Copy link
Owner

I added a flaky test and this exposed some errors:

  1. It's possible for a client to get a RETURNING_CLIENT from the server on the first successful connect if the client connection dies right as the connection is established.
  2. If a connection dies early, initSocket() could FATAL
  3. Some ServerConnection cleanup was needed to prevent crash on exit
  4. I went back to blocking sockets now that SNDTIMEO and RCVTIMEO work reliably

@MisterTea MisterTea merged commit 133b439 into master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MisterTea