Added mobile resolution scripts | Removed hardcoded url to use DEPLOY_HOST | Added pom selector for mobile #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_HOST | Added pom selector for mobile
grigoreme
suggested changes
Jul 28, 2017
| .expect(home.mobileMenu.exists).ok() | ||
| .hover(home.mobileMenu) | ||
| .click(home.mobileMenu, { speed: 0.5 }); | ||
| await t |
There was a problem hiding this comment.
Please use empty line between functions
There was a problem hiding this comment.
got it, thank you.
Fixed.
| await t | ||
| .expect(header.challengesTopMenuLink.exists).ok() | ||
| .expect(header.challengesTopMenuLink.innerText).contains('CHALLENGES'); | ||
| await t |
| await t | ||
| .expect(header.solutionsTopMenuLink.exists).ok() | ||
| .expect(header.solutionsTopMenuLink.innerText).contains('SOLUTIONS'); | ||
| await t |
| await t | ||
| .expect(header.contactTopMenuLink.exists).ok() | ||
| .expect(header.contactTopMenuLink.innerText).contains('CONTACT'); | ||
| await t |
| @@ -34,4 +32,4 @@ test('Check user can submit "Request a demo" form with valid email address', asy | |||
| visibilityCheck: true, | |||
| }).visible).ok() | |||
| .expect(Selector(requestDemoModal.responseText).innerText).contains('\nThank you for the interest in AdTechMedia WordPress Plugin\nPlease check your inbox to schedule your demo.\n'); | |||
There was a problem hiding this comment.
Get rid of that big line, you can split into new lines by functions like:
expect(
Selector(requestDemoModal.responseText).innerText)
.contains('\nThank you for the interest in AdTechMedia WordPress Plugin\nPlease check your inbox to schedule your demo.\n');```
There was a problem hiding this comment.
got it, thank you.
Fixed.
grigoreme
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.