Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[desktop_drop] feat: implement handler for unsupported URI scheme #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[desktop_drop] feat: implement handler for unsupported URI scheme #281

wants to merge 1 commit into from

Conversation

TheOneWithTheBraid
Copy link

  • add high-level callback for unsupported URI schemes
  • add HTTP and HTTPS file drop handler to example

feat: implement handler for unsupported URI scheme
cbcea13 
- add high-level callback for unsupported URI schemes
- add HTTP and HTTPS file drop handler to example

Signed-off-by: The one with the braid <[email protected]>
@TheOneWithTheBraid TheOneWithTheBraid changed the title feat: implement handler for unsupported URI scheme [desktop_drop] feat: implement handler for unsupported URI scheme Aug 26, 2023
@boyan01
Copy link
Contributor

boyan01 commented Aug 28, 2023 •
edited
Loading

Thanks for the PR.

It looks like this PR is mainly to add handling drop events for urls (not files) on Linux.

but in my opinion, refactoring the files in DropDoneDetails to uris feels a bit better.

class DropDoneDetails {
  ...

  final List<Uri> uris;

  ...
}

What are your thoughts？ @TheOneWithTheBraid

@SleepySquash SleepySquash mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheOneWithTheBraid @boyan01