Allow launching with pkexec (elementary#951)

* Allow launching with pkexec * Update Application.vala Co-authored-by: Jeremy Wootten <[email protected]>
MobileAZN · Feb 24, 2021 · 4bb9ec5 · 4bb9ec5
1 parent 881266f
commit 4bb9ec5
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 0 deletions.
diff --git a/data/code.policy.in.in b/data/code.policy.in.in
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE policyconfig PUBLIC
+ "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN"
+ "http://www.freedesktop.org/standards/PolicyKit/1.0/policyconfig.dtd">
+<policyconfig>
+  <vendor>elementary</vendor>
+  <vendor_url>https://github.com/elementary/code</vendor_url>
+  <icon_name>io.elementary.code</icon_name>
+  <action id="org.freedesktop.policykit.pkexec.io.elementary.code">
+   <description>Run Code as Administrator</description>
+   <message>Authentication is required to run Code as Administrator</message>
+   <defaults>
+     <allow_any>auth_admin</allow_any>
+     <allow_inactive>auth_admin</allow_inactive>
+     <allow_active>auth_admin</allow_active>
+   </defaults>
+     <annotate key="org.freedesktop.policykit.exec.path">@install_prefix@/@bin_dir@/@exec_name@</annotate>
+     <annotate key="org.freedesktop.policykit.exec.allow_gui">true</annotate>
+   </action>
+</policyconfig>
diff --git a/data/meson.build b/data/meson.build
@@ -49,3 +49,24 @@ appstream_file = i18n.merge_file(
     install_dir: join_paths(get_option('datadir'), 'metainfo'),
     install: true
 )
+
+config_data = configuration_data()
+config_data.set('install_prefix', get_option('prefix'))
+config_data.set('bin_dir', get_option('bindir'))
+config_data.set('exec_name', meson.project_name())
+
+policy_in = configure_file(
+    input: 'code.policy.in.in',
+    output:  meson.project_name() + '.policy.in',
+    configuration: config_data,
+    install: false,
+)
+
+i18n.merge_file(
+    'policy',
+    input: policy_in,
+    output: meson.project_name() + '.policy',
+    po_dir: join_paths(meson.source_root (), 'po', 'extra'),
+    install: true,
+    install_dir: join_paths(get_option('datadir'), 'polkit-1', 'actions'),
+)
diff --git a/po/extra/POTFILES b/po/extra/POTFILES
@@ -1,2 +1,3 @@
 data/io.elementary.code.appdata.xml.in
 data/io.elementary.code.desktop.in.in
+data/code.policy.in.in
diff --git a/src/Application.vala b/src/Application.vala
@@ -79,6 +79,13 @@ namespace Scratch {
         }
 
         public override int command_line (GLib.ApplicationCommandLine command_line) {
+            /* Only allow running with root privileges using pkexec, not using sudo */
+            if (Posix.getuid () == 0 && GLib.Environment.get_variable ("PKEXEC_UID") == null) {
+                warning ("Running Code using sudo is not possible. Use: pkexec io.elementary.code");
+                quit ();
+                return 1;
+            };
+
             var options = command_line.get_options_dict ();
 
             if (options.contains ("new-tab")) {