Xcode 11.5 support (#447)

MobileNativeFoundation · Oct 2, 2020 · 68a3b98 · 68a3b98
1 parent 0c7fa73
commit 68a3b98
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 16 deletions.
diff --git a/.github/workflows/PR.yml b/.github/workflows/PR.yml
@@ -10,8 +10,8 @@ jobs:
     steps:
       # actions/checkout@v2 but we use the SHA1 because tags can be re-written in git
       - uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
-      - name: Select Xcode 11.4
-        run: sudo xcode-select -s /Applications/Xcode_11.4.app
+      - name: Select Xcode 11.5
+        run: sudo xcode-select -s /Applications/Xcode_11.5.app
       - name: Run Bluepill tests
         run: ./scripts/bluepill.sh instance_tests
 
@@ -22,8 +22,8 @@ jobs:
     steps:
       # actions/checkout@v2 but we use the SHA1 because tags can be re-written in git
       - uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
-      - name: Select Xcode 11.4
-        run: sudo xcode-select -s /Applications/Xcode_11.4.app
+      - name: Select Xcode 11.5
+        run: sudo xcode-select -s /Applications/Xcode_11.5.app
       - name: Run BP tests
         run: ./scripts/bluepill.sh runner_tests
       - name: Build and Package

diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -15,8 +15,8 @@ jobs:
     steps:
     # actions/checkout@v2 but we use the sha because tags can be rewritten in git
     - uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
-    - name: Select Xcode 11.4
-      run: sudo xcode-select -s /Applications/Xcode_11.4.app
+    - name: Select Xcode 11.5
+      run: sudo xcode-select -s /Applications/Xcode_11.5.app
     - name: Run Bluepill tests
       run: ./scripts/bluepill.sh instance_tests
 
@@ -27,8 +27,8 @@ jobs:
     steps:
     # actions/checkout@v2 but we use the sha because tags can be rewritten in git
     - uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
-    - name: Select Xcode 11.4
-      run: sudo xcode-select -s /Applications/Xcode_11.4.app
+    - name: Select Xcode 11.5
+      run: sudo xcode-select -s /Applications/Xcode_11.5.app
     - name: Run BP tests
       run: ./scripts/bluepill.sh runner_tests
     - name: Build and Package

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,8 +13,8 @@ jobs:
     steps:
     # actions/checkout@v2 but we use the sha because tags can be rewritten in git
     - uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
-    - name: Select Xcode 11.4
-      run: sudo xcode-select -s /Applications/Xcode_11.4.app
+    - name: Select Xcode 11.5
+      run: sudo xcode-select -s /Applications/Xcode_11.5.app
     - name: Run Bluepill tests
       run: ./scripts/bluepill.sh instance_tests
 
@@ -28,8 +28,8 @@ jobs:
     - name: Report event trigger data
       run: |
         echo "Event ${{ github.event_name }}, ref: ${{ github.ref }}"
-    - name: Select Xcode 11.4
-      run: sudo xcode-select -s /Applications/Xcode_11.4.app
+    - name: Select Xcode 11.5
+      run: sudo xcode-select -s /Applications/Xcode_11.5.app
     - name: Run Bluepill tests
       run: ./scripts/bluepill.sh runner_tests
     - name: Build Bluepill

diff --git a/README.md b/README.md
@@ -97,7 +97,7 @@ A full list supported options are listed here.
 
 ## Requirements
 
-Bluepill officially supports **Xcode 11.4**. If you're looking for old Xcode support, please check out the below branches:
+Bluepill officially supports **Xcode 11.5**. If you're looking for old Xcode support, please checkout the following branches:
 
 * [Xcode-8](https://github.com/linkedin/bluepill/tree/xcode8)
 * [Xcode-9.0](https://github.com/linkedin/bluepill/tree/xcode-9.0)
@@ -113,6 +113,7 @@ Bluepill officially supports **Xcode 11.4**. If you're looking for old Xcode sup
 * [Xcode-11.1](https://github.com/linkedin/bluepill/tree/xcode-11.1)
 * [Xcode-11.2](https://github.com/linkedin/bluepill/tree/xcode-11.2)
 * [Xcode-11.3](https://github.com/linkedin/bluepill/tree/xcode-11.3)
+* [Xcode-11.4](https://github.com/linkedin/bluepill/tree/xcode-11.4)
 
 If you're looking for newer Xcode version support, try using Bluepill with `unsafe-skip-xcode-version-check` flag but make sure your app is tested with it and the underlying risks are understand.
 

diff --git a/bp/src/BPConstants.h b/bp/src/BPConstants.h
@@ -10,9 +10,9 @@
 #import <Foundation/Foundation.h>
 
 #pragma mark - Version Constants
-#define BP_DEFAULT_XCODE_VERSION "11.4"
-#define BP_DEFAULT_RUNTIME "iOS 13.4"
-#define BP_DEFAULT_BASE_SDK "13.4"
+#define BP_DEFAULT_XCODE_VERSION "11.5"
+#define BP_DEFAULT_RUNTIME "iOS 13.5"
+#define BP_DEFAULT_BASE_SDK "13.5"
 
 #define BP_DEFAULT_DEVICE_TYPE "iPhone 8"