Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12.0 support #458

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Conversation

ravimandala
Copy link
Contributor

Adding Xcode 12.0 support (Ref: Issue #453)

\cc @ob @chenxiao0228 @oliverhu @RainNapper @jerrymarino

ob
ob previously approved these changes Sep 20, 2020
Copy link
Member

@ob ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the bump!

oliverhu
oliverhu previously approved these changes Sep 20, 2020
@ob ob dismissed stale reviews from oliverhu and themself via ec9f766 September 29, 2020 00:02
ob
ob previously approved these changes Sep 29, 2020
Copy link
Member

@ob ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravimandala
Copy link
Contributor Author

Thanks @ob for the fix. Please take another look and give a 👍? Thanks.

@ravimandala ravimandala merged commit 2e80798 into MobileNativeFoundation:master Sep 29, 2020
AhmedEid added a commit to tinyspeck/bluepill that referenced this pull request Nov 18, 2020
* master:
  Reference libXCTestBundleInject.dylib only if it exists (MobileNativeFoundation#460)
  Record video using simctl (MobileNativeFoundation#441)
  Xcode 12.0 support (MobileNativeFoundation#458)
  Retry app crash tests and consider then non-fatal if they pass (MobileNativeFoundation#456)
  Do not retry crashed tests (MobileNativeFoundation#443)
  Fixing minor issues and doing some minor refactoring/clean-up (MobileNativeFoundation#444)
  Xcode 11.5 support (MobileNativeFoundation#447)
  Xcode 11.4 support (MobileNativeFoundation#446)
  Add a flag to disable Xcode version check failure (MobileNativeFoundation#436)
  Support sidecar applications (MobileNativeFoundation#438)
  Added a few more tests to mock test failure scenarios and fixed a few final Exit Status issues  (MobileNativeFoundation#430)
  make retry checks more resilient to prevent infinite retries (MobileNativeFoundation#432)
  Xcode 11.3 support (MobileNativeFoundation#426)
  Supporting tests and app hosts in subfolders (MobileNativeFoundation#419)

# Conflicts:
#	bp/src/SimulatorHelper.m
#	bp/tests/SimulatorHelperTests.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants