Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-18406] Handle airflowDagRun facet #33

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jul 26, 2024

Change Summary

Handle new facet airflowDagRun added to OpenLineage integration for Airflow in apache/airflow#40798 and OpenLineage/OpenLineage#2885.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus requested a review from TiGrib July 26, 2024 10:57
@dolfinus dolfinus self-assigned this Jul 26, 2024
@dolfinus dolfinus force-pushed the feature/DOP-18406 branch from 25c42e4 to 9947b6d Compare July 26, 2024 11:02
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.63%. Comparing base (5336e19) to head (9947b6d).

Files Patch % Lines
data_rentgen/consumer/extractors/run.py 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #33      +/-   ##
===========================================
- Coverage    91.64%   91.63%   -0.01%     
===========================================
  Files          138      138              
  Lines         2189     2212      +23     
  Branches       173      177       +4     
===========================================
+ Hits          2006     2027      +21     
- Misses         147      148       +1     
- Partials        36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TiGrib TiGrib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dolfinus dolfinus merged commit 0442298 into develop Jul 26, 2024
5 checks passed
@dolfinus dolfinus deleted the feature/DOP-18406 branch July 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants