Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V2.3-RC to V2.3-RC2 #67

Merged
merged 11 commits into from
Mar 16, 2022
Merged

Update V2.3-RC to V2.3-RC2 #67

merged 11 commits into from
Mar 16, 2022

Conversation

isabelle-dr
Copy link
Contributor

@isabelle-dr isabelle-dr commented Mar 10, 2022

On January 31, 2022, a new version of the V2.3 RC has been created.
This PR replaces the current V2.3-RC to V2.3-RC2.

The changes are:

@isabelle-dr isabelle-dr linked an issue Mar 10, 2022 that may be closed by this pull request
@isabelle-dr isabelle-dr marked this pull request as draft March 10, 2022 17:04
@isabelle-dr isabelle-dr marked this pull request as ready for review March 10, 2022 19:58
@isabelle-dr
Copy link
Contributor Author

@AntoineAugusti Do you know why the GH Action is failing?
When I validate the files manually, it works 🤨

@testower
Copy link
Collaborator

@isabelle-dr geofencing_zones.json is not valid json due to the comma at the end of this line:

https://github.com/MobilityData/gbfs-json-schema/pull/67/files#diff-ae248d41170c9dca330a4bc316f0948df60a4c9f0115628bf2d200b491dc76deR95

Remove the comma and the GitHub Action should pass.

@isabelle-dr
Copy link
Contributor Author

Good catch, these additional commas weren't flagged by the validator I used. Thanks, @testower!
I just need a review before merging.

Copy link

@mplsmitch mplsmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change related to phone number data type

v2.3-RC2/station_information.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for v2.3RC2
3 participants