Flex: missing_pickup_booking_rule_id

[emmambd]

Describe the problem

See below

Describe the new validation rule

missing_pickup_booking_rule_id as defined in the table here

Sample GTFS datasets

No response

Severity

Warning

Additional context

No response

[emmambd]

Modify this check to look for if start_pickup_drop_off_window/end_pickup_drop_off_window is defined rather than if booking_rules.txt exists

[qcdyx]

The notice description is pickup_booking_rule_id is recommended when pickup_type=2 and drop_off_booking_rule_id is
recommended when drop_off_type=2, shall I change it to start_pickup_drop_off_window should be defined when pickup_type=2 and end_pickup_drop_off_window should be defined when drop_off_type=2? @emmambd

[emmambd]

Good catch @qcdyx ! Revised description:

pickup_booking_rule_id is recommended when pickup_type=2 and drop_off_booking_rule_id is
recommended when drop_off_type=2. Currently, this notice is only triggered on feeds when either start_pickup_drop_off_window or end_pickup_drop_off_window is defined, since this recommendation was added to the specification for feeds with GTFS-Flex.