feat: modified MissingPickupDropOffBookingRuleIdNotice logic #2001
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit ffd0e53 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (125 out of 1824 datasets, ~7%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit e5b8734 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (125 out of 1824 datasets, ~7%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
Expected spec behavior here :) |
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 6bce44d 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (125 out of 1824 datasets, ~7%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
davidgamez
approved these changes
Mar 4, 2025
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/PickupBookingRuleIdValidator.java
Show resolved
Hide resolved
jcpitre
reviewed
Mar 4, 2025
| @@ -25,6 +25,7 @@ public PickupBookingRuleIdValidator( | |||
| public void validate(GtfsStopTime entity, NoticeContainer noticeContainer) { | |||
| if (entity.hasPickupType() | |||
| && entity.pickupType() == GtfsPickupDropOff.MUST_PHONE | |||
| && entity.hasStartPickupDropOffWindow() | |||
There was a problem hiding this comment.
I might misunderstand this comment: #1821 (comment)
But shouldn't it also check for entity.hasEndPickupDropOffWindow() here?
There was a problem hiding this comment.
I don't think so based on the revised logic:
- GtfsStopTime has a pickupType of 2, includes StartPickupDropOffWindow AND has a missing pickupBookingRuleId.
- GtfsStopTime has a dropOffType of 2 and includes EndPickupDropOffWindow AND has a missing dropOffBookingRuleId.
If one of the conditions is met, it should trigger MissingPickupDropOffBookingRuleIdNotice.
| @@ -34,6 +35,7 @@ public void validate(GtfsStopTime entity, NoticeContainer noticeContainer) { | |||
| } | |||
| if (entity.hasDropOffType() | |||
| && entity.dropOffType() == GtfsPickupDropOff.MUST_PHONE | |||
| && entity.hasEndPickupDropOffWindow() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1821
Expected behavior:
I've checked some feeds listed in the New Warnings #1966 in this PR, for instance, ca-quebec-exo-laurentides-gtfs-744, the dataset doesn't have a booking rules file and its report doesn't contain MissingPickupDropOffBookingRuleIdNotice. https://mobilitydatabase.org/feeds/gtfs/mdb-744
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything