Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update MissingPriorNoticeLastDayNotice and MissingPriorNoticeLastTimeNotice documentation #2002

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Mar 4, 2025

Summary:

Follow-up to PR comment.

Related to #1977

Expected behavior:

The description of MissingPriorNoticeLastDayNotice and MissingPriorNoticeLastTimeNotice is updated as suggested

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez marked this pull request as ready for review March 4, 2025 18:32
@davidgamez davidgamez requested review from Sergiodero and emmambd March 4, 2025 18:32
Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Mar 4, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 86e4c96
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1824 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.73 3.81 ⬆️+0.08
Median -- 1.37 1.39 ⬆️+0.02
Standard Deviation -- 10.93 10.97 ⬆️+0.04
Minimum in References Reports us-oregon-high-desert-point-gtfs-636 0.48 0.60 ⬆️+0.12
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 279.90 278.31 ⬇️-1.59
Minimum in Latest Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.50 0.48 ⬇️-0.02
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 279.90 278.31 ⬇️-1.59
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 471.37 MiB 467.02 MiB ⬇️-4.34 MiB
Median -- 335.92 MiB 335.92 MiB ⬇️0 bytes
Standard Deviation -- 807.78 MiB 773.76 MiB ⬇️-34.02 MiB
Minimum in References Reports nz-south-island-ebus-gtfs-2329 39.76 MiB 39.73 MiB ⬇️-31.89 KiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.70 GiB 10.64 GiB ⬇️-64.37 MiB
Minimum in Latest Reports us-colorado-boulder-county-gtfs-2191 407.92 MiB 38.82 MiB ⬇️-369.10 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.70 GiB 10.64 GiB ⬇️-64.37 MiB

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the request!

@davidgamez davidgamez merged commit 65cb9a9 into master Mar 4, 2025
142 of 143 checks passed
@davidgamez davidgamez deleted the fix/update-missing-prior-notice-comment branch March 4, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants