This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Minor Fixes #52
Merged
Minor Fixes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clear this.navigating on close() so it won't interfere with nativeKeyboard type-to-select short-circut type-to-search check (performance) don't append options to document fragment if search is not live (was causing mis-ordered options on open()) prefer highlighting selected answer on open()
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.navigatingshould be cleared on close; was disabling search-to-type after selecting an item via the keyboardsearch()should only modify the DOM for "live" searches; was resulting in mixed-up display order for optionsopen(), highlight the first selected option if any; first option otherwise