Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions: SDK & XS are empty when building with mcconfig #6

Closed
rwaldron opened this issue Dec 5, 2017 · 0 comments
Closed

Versions: SDK & XS are empty when building with mcconfig #6

rwaldron opened this issue Dec 5, 2017 · 0 comments

Comments

@rwaldron
Copy link
Contributor

rwaldron commented Dec 5, 2017

rwaldron in ~/clonez/moddable/examples/commodetto/clock on public*
$ mcconfig -d -m -p esp
# xsc main.xsb
# xsl modules
# cc mc.xs.c (slots in flash)
# ld main.bin
# Versions
#  SDK:
#  XS:

Those values are derived via:

ARDUINO_ROOT ?= $(ESP_BASE)/esp8266-2.3.0
...
git_description = $(shell git -C  $(1) describe --tags --always --dirty 2>/dev/null)
SRC_GIT_VERSION = $(call git_description,$(ESP_BASE)/sources)
ESP_GIT_VERSION = $(call git_description,$(ARDUINO_ROOT))

ARDUINO_ROOT is not a git repo ;) That directory comes from step 6:

  1. Download the ESP8266 core for Arduino repository. Copy the extracted esp8266-2.3.0 folder into your ~/esp directory

That link is for a release zip, which doesn't include .git

SRC_GIT_VERSION comes from:

$(ESP_BASE)/sources

Which I'm guessing previously existed, but no longer does. I've written a patch to follow

mkellner pushed a commit that referenced this issue Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant