Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fix joint #126

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Fix Fix joint #126

merged 3 commits into from
Oct 17, 2023

Conversation

GerhardHippmann
Copy link
Collaborator

  • Add missing coordinate transformation in parent torque computation of FixKind joint (relevant in case of non-zero rotation of obj1)
  • Update reference results of YouBot models
  • Re-enable test YouBotWithSphere

@GerhardHippmann
Fix Fix joint
4d67ed4 
- Add missing coordinate transformation in parent torque computation of FixKind joint (relevant in case of non-zero rotation of obj1)
- Update reference results of YouBot models
- Re-enable test YouBotWithSphere
@AndreaNeumayr
Copy link
Member

For me it looks fine.

@GerhardHippmann GerhardHippmann merged commit c8d4b5e into main Oct 17, 2023
@AndreaNeumayr AndreaNeumayr deleted the gh_fixFixJoint branch November 15, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinOtter MartinOtter Awaiting requested review from MartinOtter

@AndreaNeumayr AndreaNeumayr Awaiting requested review from AndreaNeumayr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GerhardHippmann @AndreaNeumayr