Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An use mpr float type #47

Merged
merged 7 commits into from
Oct 29, 2021
Merged

An use mpr float type #47

merged 7 commits into from
Oct 29, 2021

Conversation

AndreaNeumayr
Copy link
Member

implement variable MPRFloatType for all needed mpr functions

  • all runtests are working
  • no tolerance and Double64 changes

shapeKind = obj.shapeKind
solid::Modia3D.Solid = obj.feature
collisionSmoothingRadius = solid.collisionSmoothingRadius
collisionSmoothingRadius = T(solid.collisionSmoothingRadius)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could introduce variables obj_r_abs/R_abs here for easier reading.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@@ -94,7 +94,8 @@ convertAndStripUnit(TargetType, requiredUnit, value) =
numberType(value) <: Unitful.AbstractQuantity && unit.(value) != Unitful.NoUnits ?
convert(TargetType, ustrip.( uconvert.(requiredUnit, value))) : convert(TargetType, value)


# MPRFloatType is used to change betweeen Double64 and Float64 for mpr calculations
const MPRFloatType = Float64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@AndreaNeumayr AndreaNeumayr mentioned this pull request Oct 29, 2021
@GerhardHippmann
Copy link
Collaborator

Clear implementation now. :-)

@GerhardHippmann GerhardHippmann merged commit 3dc2b19 into main Oct 29, 2021
@AndreaNeumayr AndreaNeumayr deleted the an_useMPRFloatType branch November 2, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants