-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An use mpr float type #47
Conversation
shapeKind = obj.shapeKind | ||
solid::Modia3D.Solid = obj.feature | ||
collisionSmoothingRadius = solid.collisionSmoothingRadius | ||
collisionSmoothingRadius = T(solid.collisionSmoothingRadius) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could introduce variables obj_r_abs/R_abs here for easier reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
@@ -94,7 +94,8 @@ convertAndStripUnit(TargetType, requiredUnit, value) = | |||
numberType(value) <: Unitful.AbstractQuantity && unit.(value) != Unitful.NoUnits ? | |||
convert(TargetType, ustrip.( uconvert.(requiredUnit, value))) : convert(TargetType, value) | |||
|
|||
|
|||
# MPRFloatType is used to change betweeen Double64 and Float64 for mpr calculations | |||
const MPRFloatType = Float64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Clear implementation now. :-) |
implement variable MPRFloatType for all needed mpr functions