An switch to double64 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndreaNeumayr
commented
Nov 10, 2021
AndreaNeumayr
commented
- use Double64 for mpr algorithm
- change values of tol_rel and nepsType
- change final states of collisions models
AndreaNeumayr
force-pushed
the
an_switchToDouble64
branch
from
a1a4400 to
9181135
Compare
src/Composition/scene.jl
Outdated
| @@ -308,7 +308,7 @@ Defines global properties of the system, such as the gravity field. Exactly one | |||
| | `gravityField` | [`UniformGravityField`](@ref)`()` | | |||
| | `useOptimizedStructure` | true | | |||
| | `enableContactDetection` | true | | |||
| | `contactDetection` | [`ContactDetectionMPR_handler`](@ref)`()`| | |||
| | `mpr_tol_rel` | 1.0e-20 | | |||
There was a problem hiding this comment.
mprTolerance or so would be more consistent. "Relative" could be explained in docu.
There was a problem hiding this comment.
I like your suggestion. I'll change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.