An remove duplicates interface3 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndreaNeumayr
commented
Jan 25, 2022
AndreaNeumayr
commented
- remove all duplicates from ModiaInterface in Modia
- using Modia instead of Modia3D, ModiaLang and Modia3D.ModiaInterface
| @@ -49,7 +49,7 @@ stopTime = 10.0 | |||
| # requiredFinalStates = [-1.578178283450938, 0.061515170100766486] | |||
|
|
|||
| Modia3D.disableRenderer() | |||
There was a problem hiding this comment.
Better use Scene option 'enableVisualization'.
| @@ -2,6 +2,7 @@ module YouBotGripping | |||
|
|
|||
| using ModiaLang | |||
| import Modia3D | |||
There was a problem hiding this comment.
Is Modia3D still required?
There was a problem hiding this comment.
Yes, in this case it is needed for joinpath(Modia3D.path, "objects/robot_KUKA_YouBot/base_frame.obj")
AndreaNeumayr
commented
Jan 26, 2022
| @@ -10,8 +11,6 @@ include("$(ModiaLang.path)/models/Electric.jl") | |||
| include("$(ModiaLang.path)/models/Rotational.jl") | |||
| include("$(ModiaLang.path)/models/Translational.jl") | |||
There was a problem hiding this comment.
In some cases it was possilbe to replace ModiaLang as well, but here it is needed to include some models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.