Icon colours, rendering optimizations, folders #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoffKalast
changed the title
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon colours
Certain some widgets can be set to different drawing colours, it should be practical to reflect those colours in the icons as well. The current approach of using hue-rotate doesn't seem to be completely accurate so some colours don't look consistent with the actual render colour, but it's close enough.
Rendering
Turns out that now that most visualizers transform the messages they get to the fixed frame, we can skip redrawing them on every tf frame change (since fixed_frame rarely changes) for a massive rendering speed boost.
Folders
A prototype implementation for folders that have to be created separately via the add widget menu for now, but that has a neat side effect that any widgets inside them get loaded later than the folder, which makes infinite folder recursion possible without any specific handling. Currently showing the first two widget icons inside.