chore: market matching pool tidy up #100
Merged
+305
−184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the MarketMatchingPool account to include the data used as seeds in the data stored in the account. This should make it easy for anyone using/building on the protocol to interact with MarketMatchingPools.
This also enables the addition of
getProgramAccounts
queries for these accounts simplifying the fetching of interesting MarketMatchingPools.The fields added are:
As the seeds are stored on the account now, including the market pk, there was no longer any need to rely on validation of the seeds in the CloseMarketMatchingPool context to ensure the market was valid for the matching pool. This can now be done using a
has_one
constraint.Additionally
purchaser
was renamed topayer
to better fit convention in the protocol.A bug was also discovered in the client query code when fields being used as filters were non-contiguous incorrect filtering would occur. This has been fixed in this PR also.