Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add secure properties to express session cookie #127

Merged
merged 2 commits into from
Mar 15, 2022
Merged

fix: add secure properties to express session cookie #127

merged 2 commits into from
Mar 15, 2022

Conversation

rutajdash
Copy link
Member

Solved or Linked Issues

Fixes #125

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a work/topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the development (left side). Also you should start your branch off default branch and follow the branch naming guidelines.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation and mentioned the related issues (if appropriate)
  • I have added the appropriate labels, requested a review from a repository manager and assigned myself to this pull request.

Post merge checklist

@rutajdash rutajdash added the bugfix Some Bug was Fixed label Mar 15, 2022
@rutajdash rutajdash added this to the Phase 1 Launch milestone Mar 15, 2022
@rutajdash rutajdash self-assigned this Mar 15, 2022
@rutajdash rutajdash merged commit aaed336 into Monday-Morning:main Mar 15, 2022
@rutajdash rutajdash deleted the fix/125 branch March 15, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Some Bug was Fixed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix: express cookie store in production
1 participant